lousando/briskett
1
0
Fork 0
Code Issues 7 Pull requests Projects Releases Packages Wiki Activity Actions

changed name to NUXT_ENV_TZPRO_URL #21

Merged
GajendraR merged 2 commits from new into master 2023-11-22 15:24:34 +00:00
Conversation 4 Commits 2 Files changed 4 +8 -7
GajendraR commented 2023-11-21 17:04:57 +00:00 (Migrated from github.com)
Copy link

changed name of env variable to NUXT_ENV_TZPRO_URL
issue_number - #20

changed name of env variable to NUXT_ENV_TZPRO_URL issue_number - #20
lousando (Migrated from github.com) requested changes 2023-11-21 23:27:07 +00:00
lousando (Migrated from github.com) left a comment
Copy link

Thank you for your help :)
I just request one change please so I can merge this :)

Thank you for your help :) I just request one change please so I can merge this :)
.env.example
@ -6,11 +6,12 @@ NUXT_ENV_TREZOR_MANIFEST_EMAIL=""
NUXT_ENV_TREZOR_MANIFEST_APP_URL=""
lousando (Migrated from github.com) commented 2023-11-21 23:24:37 +00:00
Copy link

Can you leave the NUXT_ENV_TZPRO_API_KEY empty and add the URL as a comment?
I'd rather we have the default value be a falsy value instead of additional documentation.

e.g.

NUXT_ENV_TZPRO_API_KEY="" # https://docs.tzpro.io/intro/access

or

# https://docs.tzpro.io/intro/access
NUXT_ENV_TZPRO_API_KEY=""
Can you leave the `NUXT_ENV_TZPRO_API_KEY` empty and add the URL as a comment? I'd rather we have the default value be a falsy value instead of additional documentation. e.g. `NUXT_ENV_TZPRO_API_KEY="" # https://docs.tzpro.io/intro/access` or ``` # https://docs.tzpro.io/intro/access NUXT_ENV_TZPRO_API_KEY="" ```
GajendraR (Migrated from github.com) reviewed 2023-11-22 06:44:48 +00:00
.env.example
@ -6,11 +6,12 @@ NUXT_ENV_TREZOR_MANIFEST_EMAIL=""
NUXT_ENV_TREZOR_MANIFEST_APP_URL=""
GajendraR (Migrated from github.com) commented 2023-11-22 06:44:48 +00:00
Copy link

ok

ok
GajendraR (Migrated from github.com) reviewed 2023-11-22 06:59:46 +00:00
.env.example
@ -6,11 +6,12 @@ NUXT_ENV_TREZOR_MANIFEST_EMAIL=""
NUXT_ENV_TREZOR_MANIFEST_APP_URL=""
GajendraR (Migrated from github.com) commented 2023-11-22 06:59:46 +00:00
Copy link

I have set NUXT_ENV_TZPRO_API_KEY to an empty value and included the URL as a comment.

I have set NUXT_ENV_TZPRO_API_KEY to an empty value and included the URL as a comment.
lousando (Migrated from github.com) approved these changes 2023-11-22 15:23:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
lousando
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lousando/briskett!21
No description provided.